[FFmpeg-devel] [PATCH 4/4] lavf/mov: Add support for edit list parsing.

[Sasi Inguva]

oops. thanks for pointing that out. Even in our version of ffmpeg, that
assert doesn't get compiled so we never catched it. That assert logic is
not correct anymore. At the end of one edit list there can be frames marked
as discard, for which we would keep increasing the timestamp even if they
are marked as discard, so that when the timestamps are rerodered to compute
PTS B-frames get the correct PTS. But the next edit list should always
start with the timestamp of the last-non-discarded frame of the previous
edit list. Hence we will get non-increasing timestamps added as index
entries.

The test may have passed for you before, because before that line was
assert(..) instead of av_assert1(...) so maybe that line wasn't getting
compiled before. Attaching the 4 patches again.



On Wed, Aug 24, 2016 at 7:37 PM, Michael Niedermayer <michael at niedermayer.cc
> wrote:

> On Wed, Aug 24, 2016 at 06:42:16PM -0700, Sasi Inguva wrote:
> > hmm. strange. I just rebased my branch on top of head, and reran the
> test,
> > and it succeeds along with all other fate tests. I am attaching the 4
> > patches again here.
>
> you need to build with
> --assert-level=2
> to see the failure
>
> [...]
>
> --
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>
> He who knows, does not speak. He who speaks, does not know. -- Lao Tsu
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-avutil-frame-Add-a-flag-to-discard-frame-after-decod.patch
Type: text/x-patch
Size: 1670 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160825/e04471a3/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-lavf-mov-Add-support-for-edit-list-parsing.patch
Type: text/x-patch
Size: 117722 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160825/e04471a3/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-lavc-Add-a-flag-in-AVPacket-to-discard-packet-after-.patch
Type: text/x-patch
Size: 3487 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160825/e04471a3/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-avformat-avframe.h-Add-a-flag-in-AVIndexEntry-to-dis.patch
Type: text/x-patch
Size: 1818 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160825/e04471a3/attachment-0003.bin>