[FFmpeg-devel] [PATCH] mov: Remove ancient heuristic hack

[Michael Niedermayer]

On Thu, Aug 25, 2016 at 05:46:57PM +0100, Derek Buitenhuis wrote:
> On 8/25/2016 5:34 PM, James Almer wrote:
> > On 8/25/2016 12:45 PM, Carl Eugen Hoyos wrote:
> >> 2016-08-24 16:55 GMT+02:00 Derek Buitenhuis <derek.buitenhuis at gmail.com>:
> >>> This breaks files with legitimate single-entry edit lists,
> >>
> >>> and the hack, introduced in f03a081df09f9c4798a17d7e24446ed47924b11b,
> >>
> >> I believe "Hack" is not acceptable on this mailing list anymore, please
> >> remove it from the commit message.
> > 
> > Care to point where this was discussed or agreed by the bulk of developers?
> > I don't recall anything about it.
> > A quick search for "hack" shows a lot of recent results in both the ML and
> > the git repo, so I'm not sure why you assumed it's "not acceptable" anymore.
> 
> What's a better word? "incorrect workaround"? Am I not allow to say
> some code is wrong? Because the code is defacto incorrect.

this is not really my area and i might misguess what was meant so
i can only speak about what my feeling woudl suggest

"Hack" might suggest the author had knowledge of the code being not
the correct solution when adding it. Maybe this felt offensive


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In a rich man's house there is no place to spit but his face.
-- Diogenes of Sinope
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160825/3997072a/attachment.sig>