[FFmpeg-devel] [PATCH 2/6] lavf/vpp: Enable vpp filter, an Intel GPU accelerated scaler.

Hendrik Leppkes h.leppkes at gmail.com
Thu Aug 25 13:21:36 EEST 2016


On Thu, Aug 25, 2016 at 2:24 AM, Jean-Baptiste Kempf <jb at videolan.org> wrote:
> On 25 Aug, Nablet Developer wrote :
>> -int ff_qsv_init_internal_session(AVCodecContext *avctx, QSVSession *qs)
>> +int ff_qsv_init_internal_session(void *avctx, QSVSession *qs)
>> -int ff_qsv_init_internal_session(AVCodecContext *avctx, QSVSession *qs);
>> +int ff_qsv_init_internal_session(void *avctx, QSVSession *qs);
>
> This is very ugly, and I doubt it's a good idea.


More precisely, it wont ever work. You cannot use ff_* functions
outside the library they are defined in.
And before you start renaming them, we really do not want QSV-specific
public API functions of any form. All hardware accelerated API should
go through avutl hwcontext now, and not create new public API.

- Hendrik


More information about the ffmpeg-devel mailing list