[FFmpeg-devel] [PATCH] Nvidia NVENC 10-bit HEVC encoding and rate control lookahead support

[Oliver Collyer]

Hi Carl

Thanks for looking at my patch.

> On 23 Aug 2016, at 21:21, Carl Eugen Hoyos <ceffmpeg at gmail.com> wrote:
> 
> Hi!
> 
> 2016-08-23 19:10 GMT+02:00 Oliver Collyer <ovcollyer at mac.com>:
>> +    AV_PIX_FMT_YUV420P10LE,
> 
> I know this is theoretical but the Nvidia header seems to indicate
> native endianness to me, so this should be AV_PIX_FMT_YUV420P10
> 
>> +    AV_PIX_FMT_YUV444P10LE
> 
> But after reading the rest of the patch:
> Shouldn't this be AV_PIX_FMT_YUV444P16?
> 

How so - the Nvidia doc is stating that the encoder is taking 10 bits per component, not 16?

> And instead of YUV420P10, shouldn't you use P010LE?
> 

Yes, I agree with this.

> In any case, please split the rate control patch from the 10bit patch.
> 

Ok, I will do that.

Oliver

> Carl Eugen
> 
> who wonders now how the Microsoft headers define the ten bit
> yuv420 semi-planar format...
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel