[FFmpeg-devel] [PATCH 05/21] libavformat/movenc: mov_write_ftyp_tag: write the major brand a compatible brand

[Yusuke Nakamura]

2016-08-23 18:03 GMT+09:00 <erkki.seppala.ext at nokia.com>:

> From: Erkki Seppälä <erkki.seppala.ext at nokia.com>
>
> Signed-off-by: Erkki Seppälä <erkki.seppala.ext at nokia.com>
> Signed-off-by: OZOPlayer <OZOPL at nokia.com>
> ---
>  libavformat/movenc.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/libavformat/movenc.c b/libavformat/movenc.c
> index 8c4252d..34bc235 100644
> --- a/libavformat/movenc.c
> +++ b/libavformat/movenc.c
> @@ -4203,6 +4203,8 @@ static int mov_write_ftyp_tag(AVIOContext *pb,
> AVFormatContext *s)
>
>      avio_wb32(pb, minor);
>
> +    if (mov->mode == MODE_MP4 && mov->major_brand)
> +        ffio_wfourcc(pb, mov->major_brand); /* write major brand as a
> compatible brand */
>

WTF. libavformat has not listed all compatible brands? This is a wrong
approach if what David Singer (Apple) says is correct. The major_brand
always be written into compatible_brands in ISOBMFF.


>      if (mov->mode == MODE_MOV)
>          ffio_wfourcc(pb, "qt  ");
>      else if (mov->mode == MODE_ISM) {
> --
> 2.7.4
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>