[FFmpeg-devel] [PATCH] avfilter: add maskedclamp filter

[Paul B Mahol]

On Monday, August 22, 2016, Moritz Barsnick <barsnick at gmx.net> wrote:

> On Mon, Aug 22, 2016 at 11:27:12 +0200, Paul B Mahol wrote:
>
> I have no idea what the result looks like, but perhaps "looks like" is
> thinking too unhypothetical. ;-) Anyways:
>
> > +Clamp the first input stream with the second input and third input
> stream.
>
> Perhaps: Clamp the first input stream's pixel values with the second
> input and third input stream.
>
> > +Returns the value of first stream to be between second input
> > +stream - @code{undershoot} and third input stream + @code{overshoot}.
>
> Same here.
>
> > +static const AVOption maskedclamp_options[] = {
> > +    { "undershoot", "set undershoot", OFFSET(undershoot),
> AV_OPT_TYPE_INT, {.i64=0}, 0, INT_MAX, FLAGS },
> > +    { "overshoot",  "set overshoot",  OFFSET(overshoot),
> AV_OPT_TYPE_INT, {.i64=0}, 0, INT_MAX, FLAGS },
>
> Could these not just as well be used with negative values? (They are
> like constant offsets to the masks, right?)


It could, but I dislike such idea.