[FFmpeg-devel] [PATCHv2] af_hdcd: Extract generic HDCD decoder, wrap for ffmpeg

[Michael Niedermayer]

On Tue, Aug 16, 2016 at 05:16:49AM -0500, Burt P wrote:
> af_hdcd.c began as an extended hdcd_decode.c from foo_hdcd, and
> recently the ffmpeg improvements were put back into a form that
> worked with foo_hdcd, but maintaining that sharing is cumbersome.
> 
> This patch moves the core HDCD decoder out of af_hdcd.c into
> hdcd_decode2.c. This is a generic version of the decoder that
> can be used in ffmpeg, foo_hdcd and whatever else. This way it is
> easier to share improvements to the decoder between projects.
> 
> af_hdcd.c is now an ffmpeg-specific wrapper to hdcd_decoder2.{h,c}.
> 
> Signed-off-by: Burt P <pburt0 at gmail.com>
> ---
>  libavfilter/Makefile       |    1 +
>  libavfilter/af_hdcd.c      | 1674 ++++----------------------------------------
>  libavfilter/hdcd_decode2.c | 1633 ++++++++++++++++++++++++++++++++++++++++++
>  libavfilter/hdcd_decode2.h |  204 ++++++

with -C this is a bit smaller though still large
not sure what is best for review

 libavfilter/Makefile                      |    1 +
 libavfilter/af_hdcd.c                     | 1674 ++---------------------------
 libavfilter/{af_hdcd.c => hdcd_decode2.c} |  958 +++++++----------
 libavfilter/hdcd_decode2.h                |  203 ++++
 4 files changed, 724 insertions(+), 2112 deletions(-)
 copy libavfilter/{af_hdcd.c => hdcd_decode2.c} (86%)
 create mode 100644 libavfilter/hdcd_decode2.h

also
breaks fate

-- ./tests/ref/fate/source     2016-08-16 11:23:33.584756114 +0200
++ tests/data/fate/source      2016-08-16 15:51:48.601095192 +0200
@@ -26,3 +26,4 @@
 compat/avisynth/windowsPorts/windows2linux.h
 compat/float/float.h
 compat/float/limits.h
+libavfilter/hdcd_decode2.h
Test source failed. Look at tests/data/fate/source.err for details.
make: *** [fate-source] Error 1
make: *** Waiting for unfinished jobs....

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Concerning the gods, I have no means of knowing whether they exist or not
or of what sort they may be, because of the obscurity of the subject, and
the brevity of human life -- Protagoras
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160816/3ab1b3e3/attachment.sig>