[FFmpeg-devel] [PATCH] libavcodec/dnxhdenc: remove setting the codec_tag

[Michael Niedermayer]

On Sun, Aug 07, 2016 at 04:35:35PM -0700, Mark Reid wrote:
> On Fri, Aug 5, 2016 at 4:28 AM, Michael Niedermayer
> <michael at niedermayer.cc> wrote:
> > On Fri, Aug 05, 2016 at 12:58:10PM +0200, Paul B Mahol wrote:
> >> On 8/5/16, Michael Niedermayer <michael at niedermayer.cc> wrote:
> >> > On Wed, Aug 03, 2016 at 02:31:04PM -0700, Mark Reid wrote:
> >> >> setting the codec_tag no longer needed by movenc
> >> >> it uses the dnxhr profile instead
> >> >> ---
> >> >>  libavcodec/dnxhdenc.c | 3 ---
> >> >>  1 file changed, 3 deletions(-)
> >> >>
> >> >> diff --git a/libavcodec/dnxhdenc.c b/libavcodec/dnxhdenc.c
> >> >> index b0ee8a2..cbf4cd5 100644
> >> >> --- a/libavcodec/dnxhdenc.c
> >> >> +++ b/libavcodec/dnxhdenc.c
> >> >> @@ -341,9 +341,6 @@ static av_cold int dnxhd_encode_init(AVCodecContext
> >> >> *avctx)
> >> >>      }
> >> >>      av_log(avctx, AV_LOG_DEBUG, "cid %d\n", ctx->cid);
> >> >>
> >> >> -    if (ctx->cid >= 1270 && ctx->cid <= 1274)
> >> >> -        avctx->codec_tag = MKTAG('A','V','d','h');
> >> >
> >> > does this not break older libavformat ?
> >> > newer libavcodec could be used with older libavformat
> >>
> 
> In that case I can just leave it as is and drop the patch. It was bit
> unclear as to whether the encoder was allowed to set codec_tag and
> thats why I was trying to clean it up.

you could put it under some #if FF_API_WHATEVER
so we get rid of this eventually ...


> 
> >> Are you serious? That kind of scenario is bad idea and it never worked
> >> and was never tested.
> >
> > its tested by the users of binary packages in linux distros
> > debian and ubuntu being examples
> >
> > each lib has major, minor and micro versions
> >
> >     MAJOR version when you make incompatible API changes,
> >     MINOR version when you add functionality in a backwards-compatible manner, and
> >     PATCH version when you make backwards-compatible bug fixes.
> > (taken from http://semver.org/)
[...]

> as this would be a small change in behaviour and not a binary
> incompatibility would this then be a MINOR bump?

IIUC its not backwards-compatible

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Democracy is the form of government in which you can choose your dictator
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160812/49ae1973/attachment.sig>