[FFmpeg-devel] [Libav-user] [PATCH]Fix a crash in vaapi_encode if "." is not the decimal separator

[Michael Niedermayer]

On Tue, Aug 02, 2016 at 08:56:46PM +0100, Mark Thompson wrote:
> On 02/08/16 18:39, Nicolas George wrote:
> > Le sextidi 16 thermidor, an CCXXIV, Carl Eugen Hoyos a écrit :
> >> -    { "i_qfactor",      "1.0" },
> >> -    { "i_qoffset",      "0.0" },
> >> -    { "b_qfactor",      "1.2" },
> >> -    { "b_qoffset",      "0.0" },
> >> +    { "i_qfactor",      "1"   },
> >> +    { "i_qoffset",      "0"   },
> >> +    { "b_qfactor",      "6/5" },
> >> +    { "b_qoffset",      "0"   },
> 
> Urgh :(  I did not consider this problem at all when writing the code.

patch does no harm and fixes this, also its easy backportable with
no risk of regressions, thus iam in favor of this patch but iam
not the maintainer of the files

Fixing this the correct way by replacing strtod or package maintainers
patching user apps locale has a much higher chance of regressions.

No question, that the proper solution is fixing the locale so it
is set to a value we support (or us properly supporting other locales
but i think this lacks volunteers and interrest)

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Old school: Use the lowest level language in which you can solve the problem
            conveniently.
New school: Use the highest level language in which the latest supercomputer
            can solve the problem without the user falling asleep waiting.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160804/f1b71df0/attachment.sig>