[FFmpeg-devel] [PATCH 1/3] lavc/bsf: add a null bitstream filter.

[Nicolas George]

Le decadi 10 floréal, an CCXXIV, Hendrik Leppkes a écrit :
> It probably does generally no harm to include it since its tiny,

That was my reasoning.

> however it would still show up in configure and be disable-able in
> configure (since the list is generated from the extern const bitstream
> filter entries in bitstream_filters.c) - it would just not actually
> disable it.
> I think this is rather confusing.

Indeed. Still, some users may think they do not need bitstream filters and
configure with --disable-bsfs, and end up with non-working applications
because they require this one to handle the no-filtering case. That is
confusing too.

I changed the declaration to hide it from configure.

> Also, something I forgot, there is a plan to generate the
> bitstream_filters array from configure instead of hardcoding it, which
> would make special cases not governed by the usual rules a bit more
> annoying.

I am rather more optimistic: the array is generated by configure, but the
declaration of the array,
"static const AVBitStreamFilter *bitstream_filters[] = {",
needs to be hardcoded somewhere. Adding the hardcoded filters there should
be easy enough.

IMHO, the cleanest design would be to have configure generate just the list,
and have:

static const AVBitStreamFilter *bitstream_filters[] = {
#include "bistream_filters_list.h"
};

Inserting null before #include is no problem.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-lavc-bsf-add-a-null-bitstream-filter.patch
Type: text/x-diff
Size: 2069 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160428/8e68541e/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160428/8e68541e/attachment.sig>