[FFmpeg-devel] [PATCH] qsvenc_hevc: Fix usage of ff_hevc_extract_rbsp

Michael Niedermayer michael at niedermayer.cc
Tue Apr 26 01:52:11 CEST 2016

On Tue, Apr 26, 2016 at 12:00:16AM +0100, Derek Buitenhuis wrote:
> On 4/25/2016 11:37 PM, Michael Niedermayer wrote:
> > i cant easily test this but does this need a
> > av_freep of skipped_bytes_pos somewhere ?
> > 
> > otherwise it should be ok
> I cannot easily test it either, unfortunately.
> I'm not sure why it would, though (without having looked very hard).

ive missed that the av_reallocp_array is under a skipped_bytes_pos!=NULL

so it should be ok

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Its not that you shouldnt use gotos but rather that you should write
readable code and code with gotos often but not always is less readable
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160426/0701af5b/attachment.sig>

More information about the ffmpeg-devel mailing list