[FFmpeg-devel] [PATCH] lavf/concatdec: remove unrelated change during codecpar merge.

Nicolas George george at nsup.org
Mon Apr 25 13:59:50 CEST 2016

Le sextidi 6 floréal, an CCXXIV, Derek Buitenhuis a écrit :
> Removing this causes failures when concatdec is used to concat two H.264
> streams from an MP4 source, when remuxed, IIRC.
> Example: https://trac.ffmpeg.org/raw-attachment/ticket/3108/examplefiles.zip
> ./ffmpeg -f concat -i tickets/3108/concatfile.txt -codec copy out.mp4

This one seems to work, but remuxing to Matroska shows problem, even with
H.264 encoded from testsrc.

I fixed it by clearing the extradata at the place where the bistream filter
is inserted, since the bsf API does not do it. See the attached patch, to be
applied on top of the small revert.

Andrey, is it similar to what you proposed?

Note to self or others: TODO: add FATE tests, including the stitchable case.


  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-lavf-concatdec-clear-extradata-when-inserting-h264_m.patch
Type: text/x-diff
Size: 1148 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160425/58ad7779/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160425/58ad7779/attachment.sig>

More information about the ffmpeg-devel mailing list