[FFmpeg-devel] [PATCH v10 2/3][GSOC] avformat/tee: Fix leaks in tee muxer when open_slave fails

Marton Balint cus at passwd.hu
Fri Apr 22 20:09:35 CEST 2016

On Fri, 22 Apr 2016, Nicolas George wrote:

> Le duodi 2 floréal, an CCXXIV, sebechlebskyjan at gmail.com a écrit :
>> From: Jan Sebechlebsky <sebechlebskyjan at gmail.com>
>> In open_slave failure can happen before bsfs array is initialized,
>> close_slave must check that bsfs is not NULL before accessing
>> tee_slave->bsfs[i] element.
>> Slave muxer expects write_trailer to be called if it's
>> write_header suceeded (so resources allocated in write_header
>> are freed). Therefore if failure happens after successfull
>> write_header call, we must ensure that write_trailer of
>> that particular slave is called.
>> Some cleanups are made by Marton Balint.
>> Signed-off-by: Jan Sebechlebsky <sebechlebskyjan at gmail.com>
>> Signed-off-by: Marton Balint <cus at passwd.hu>
> Looks ok.

Thanks applied.


More information about the ffmpeg-devel mailing list