[FFmpeg-devel] [PATCH] libnut: Pass stream to ff_parse_specific_params

[Michael Niedermayer]

On Thu, Apr 21, 2016 at 01:52:46PM +0100, Derek Buitenhuis wrote:
> This function bo longer takes an AVCodecContext.
> 
> Fixes ticket #5430.
> 
> Signed-off-by: Derek Buitenhuis <derekb at vimeo.com>
> ---
> Since I'm sending this patch anyway, I had a few questions:
> 
>   1. Where the heck is libnut's official repo. Google only turns up
>      random GitHub forks, and a link to MultiMediawiki, which in turn
>      has a link to git://git.ffmpeg.org/nut, which is not listed on ANY
>      website except this wiki, and, which in turn, is a git mirror of
>      svn://svn.mplayerhq.hu/nut, which I also cannot find listed anywhere.
>      As far as I can tell, libnut does not exist in any searchable way.
>   2. Given that we have both a native nut muxer and demuxer, and what I
>      listed in the point above, why do we keep libnut.c? It took *two
>      weeks* for someone to even notice it didn't compiled, and even
>      they didn't give any legitimate reason why they needed it.
> 
> Food for thought.
> ---
>  libavformat/libnut.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libavformat/libnut.c b/libavformat/libnut.c
> index 48f0928..26bb354 100644
> --- a/libavformat/libnut.c
> +++ b/libavformat/libnut.c
> @@ -94,7 +94,7 @@ static int nut_write_header(AVFormatContext * avf) {
>          s[i].fourcc = av_malloc(s[i].fourcc_len);
>          for (j = 0; j < s[i].fourcc_len; j++) s[i].fourcc[j] = (fourcc >> (j*8)) & 0xFF;
>  
> -        ff_parse_specific_params(codec, &num, &ssize, &denom);
> +        ff_parse_specific_params(avf->streams[i], &num, &ssize, &denom);

LGTM

thx

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No snowflake in an avalanche ever feels responsible. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160421/b9ade42f/attachment.sig>