[FFmpeg-devel] [PATCH v10 3/3][GSOC] avformat/tee: Handling slave failure in tee muxer

Nicolas George george at nsup.org
Wed Apr 20 23:14:55 CEST 2016

Le duodi 2 floréal, an CCXXIV, sebechlebskyjan at gmail.com a écrit :

> +        if (av_strerror(err_n, errbuf, sizeof(errbuf)) < 0)
> +            errbuf_ptr = strerror(AVUNERROR(err_n));

strerror() should not be used, even though a few places still use it.
Furthermore, there is no reasonable reason for av_strerror() to fail and
strerror() to succeed.

I suggest you use av_err2str(), like the rest of the modern FFmpeg code.

I did not look at the rest of the patch, under the assumption that only this
bit changed. If not, please tell me (and in the future write it in the
comment part of the Git mail).

Also, no need to Cc me, I am subscribed to the list; just following the
reply-to as is normally done by default should be good.

I will look at the other patch soon.


  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160420/65f0ec5f/attachment.sig>

More information about the ffmpeg-devel mailing list