[FFmpeg-devel] [PATCH]lavc/pgssubdec: Fix palette colourspace

Carl Eugen Hoyos cehoyos at ag.or.at
Sun Apr 17 20:40:47 CEST 2016

Jan Ekstrom <jeebjp <at> gmail.com> writes:

> On Sun, Apr 17, 2016 at 6:25 PM, Carl Eugen Hoyos wrote:
> > Attached patch fixes ticket #4637 for me.

> Can you please explain the difference between these two 
> YCbCr-to-RGB conversion functions?

I fear you don't accept "it looks black instead of gray" 
as an answer?

> The result, if it is now black, seems to match what MPC-HC's 
> subtitle renderer does, which was recently (a year or two ago) 
> updated to work more according to the HDMV graphic stream 
> specification.

Do you remember the specific file(s) used for testing?
Or how the change looked like?

> I think wm4's primary concern is that the change is not backed 
> by any explanation regarding why it is incorrect or if this is 
> even the right place to fix the issue.

I (still) cannot answer this question, sorry.

Carl Eugen

More information about the ffmpeg-devel mailing list