[FFmpeg-devel] [PATCH]lavc/pgssubdec: Fix palette colourspace
Reimar.Doeffinger at gmx.de
Sun Apr 17 20:21:51 CEST 2016
On Sun, Apr 17, 2016 at 05:54:00PM +0000, Carl Eugen Hoyos wrote:
> wm4 <nfxjfg <at> googlemail.com> writes:
> > What proves that the sample you have renders correctly now?
> You think that it is more likely that the sample was
> intentionally made to fool the vlc developers than to
> help them?
I don't like this "passive-aggressive" arguing style
you are using on each other...
FWIW, I agree with Carl that lacking a sample it makes worse
while having a simple it improves, applying this
seems to be reasonable.
But I agree with wm4 that it would be good to have
a better explanation/reasoning than just a single sample.
In particular, I have an uncomfortable suspicion that
PGS might be designed to match the movie's colour space,
in which case neither variant would give correct results
but instead it would have to depend on what format the
corresponding video track uses (and it probably would
be more than just the 255/224 factor that would differ).
More information about the ffmpeg-devel