[FFmpeg-devel] [PATCH] Implement hdcd filtering

Michael Niedermayer michael at niedermayer.cc
Thu Apr 14 02:52:39 CEST 2016

On Tue, Apr 12, 2016 at 04:28:20PM +0200, Benjamin St wrote:
> >
> > Please compress the input sample with a lossless audio
> > encoder.
> >
> Ok, input is know compressed with flac.
>  Note that you also have to send a patch that adds the
> > new license to allow fate to pass.
> Fate is passing know.
> Seems that
> >  Redistribution and use in source and binary forms, with or without
> > modification
> >
> is already ok. It just need to be in one line.


> +static int hdcd_envelope(int *samples, int count, int stride, int gain, int target_gain, int extend)
> +{
> +    int i;
> +

please add somewhere a av_assert0() that ensures that the length
that is written to is within the number of samples
the code that sets that value is complex and spread out enugh that
i think this should be explicitly checked

no more comments from me, further review & apply left to others&mentor



Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If you drop bombs on a foreign country and kill a hundred thousand
innocent people, expect your government to call the consequence
"unprovoked inhuman terrorist attacks" and use it to justify dropping
more bombs and killing more people. The technology changed, the idea is old.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160414/412b0b4c/attachment.sig>

More information about the ffmpeg-devel mailing list