[FFmpeg-devel] [PATCH] ffplay: convert to codecpar

[Michael Niedermayer]

On Mon, Apr 11, 2016 at 11:11:00PM +0200, Marton Balint wrote:
> Signed-off-by: Marton Balint <cus at passwd.hu>
> ---
>  ffplay.c | 56 ++++++++++++++++++++++++++++++++++----------------------
>  1 file changed, 34 insertions(+), 22 deletions(-)

seems working, also no new issue in valgrind in my quick test
there are some sdl/x11 related leaks though but they are not new

==16410== Thread 1:
==16410== 1 bytes in 1 blocks are definitely lost in loss record 1 of 352
==16410==    at 0x4C2C66F: malloc (vg_replace_malloc.c:270)
==16410==    by 0x52977CD: _XlcDefaultMapModifiers (in /usr/lib/x86_64-linux-gnu/libX11.so.6.3.0)
==16410==    by 0x5297BC5: XSetLocaleModifiers (in /usr/lib/x86_64-linux-gnu/libX11.so.6.3.0)
==16410==    by 0x6B4987B: ??? (in /usr/lib/x86_64-linux-gnu/libSDL-1.2.so.0.11.3)
==16410==    by 0x6B4A4A2: ??? (in /usr/lib/x86_64-linux-gnu/libSDL-1.2.so.0.11.3)
==16410==    by 0x6B3AAEC: SDL_VideoInit (in /usr/lib/x86_64-linux-gnu/libSDL-1.2.so.0.11.3)
==16410==    by 0x6B111AB: SDL_InitSubSystem (in /usr/lib/x86_64-linux-gnu/libSDL-1.2.so.0.11.3)
==16410==    by 0x6B1121B: SDL_Init (in /usr/lib/x86_64-linux-gnu/libSDL-1.2.so.0.11.3)
==16410==    by 0x49F9A8: ??? (in /home/michael/ffmpeg-git/ffmpeg/ffplay)
==16410==    by 0xFFF676C: (below main) (libc-start.c:226)
==16410==
==16410== 14 bytes in 2 blocks are definitely lost in loss record 9 of 352
==16410==    at 0x4C2C66F: malloc (vg_replace_malloc.c:270)
==16410==    by 0x1005CDA1: strdup (strdup.c:43)
==16410==    by 0x52A6A0D: ??? (in /usr/lib/x86_64-linux-gnu/libX11.so.6.3.0)
==16410==    by 0x52A7923: _XimSetICValueData (in /usr/lib/x86_64-linux-gnu/libX11.so.6.3.0)
==16410==    by 0x52A2FDE: _XimLocalCreateIC (in /usr/lib/x86_64-linux-gnu/libX11.so.6.3.0)
==16410==    by 0x5288A92: XCreateIC (in /usr/lib/x86_64-linux-gnu/libX11.so.6.3.0)
==16410==    by 0x6B49556: ??? (in /usr/lib/x86_64-linux-gnu/libSDL-1.2.so.0.11.3)
==16410==    by 0x6B4A4A2: ??? (in /usr/lib/x86_64-linux-gnu/libSDL-1.2.so.0.11.3)
==16410==    by 0x6B3AAEC: SDL_VideoInit (in /usr/lib/x86_64-linux-gnu/libSDL-1.2.so.0.11.3)
==16410==    by 0x6B111AB: SDL_InitSubSystem (in /usr/lib/x86_64-linux-gnu/libSDL-1.2.so.0.11.3)
==16410==    by 0x6B1121B: SDL_Init (in /usr/lib/x86_64-linux-gnu/libSDL-1.2.so.0.11.3)
==16410==    by 0x49F9A8: ??? (in /home/michael/ffmpeg-git/ffmpeg/ffplay)
==16410==
==16410== 192 (16 direct, 176 indirect) bytes in 1 blocks are definitely lost in loss record 276 of 352
==16410==    at 0x4C2C861: realloc (vg_replace_malloc.c:662)
==16410==    by 0x528E42B: ??? (in /usr/lib/x86_64-linux-gnu/libX11.so.6.3.0)
==16410==    by 0x528E8BD: ??? (in /usr/lib/x86_64-linux-gnu/libX11.so.6.3.0)
==16410==    by 0x528FE90: ??? (in /usr/lib/x86_64-linux-gnu/libX11.so.6.3.0)
==16410==    by 0x5290665: _XlcCreateLC (in /usr/lib/x86_64-linux-gnu/libX11.so.6.3.0)
==16410==    by 0x52ADB4F: _XlcDefaultLoader (in /usr/lib/x86_64-linux-gnu/libX11.so.6.3.0)
==16410==    by 0x5297A01: _XOpenLC (in /usr/lib/x86_64-linux-gnu/libX11.so.6.3.0)
==16410==    by 0x5297B47: _XlcCurrentLC (in /usr/lib/x86_64-linux-gnu/libX11.so.6.3.0)
==16410==    by 0x5297B9D: XSetLocaleModifiers (in /usr/lib/x86_64-linux-gnu/libX11.so.6.3.0)
==16410==    by 0x6B4982B: ??? (in /usr/lib/x86_64-linux-gnu/libSDL-1.2.so.0.11.3)
==16410==    by 0x6B4A4A2: ??? (in /usr/lib/x86_64-linux-gnu/libSDL-1.2.so.0.11.3)
==16410==    by 0x6B3AAEC: SDL_VideoInit (in /usr/lib/x86_64-linux-gnu/libSDL-1.2.so.0.11.3)
==16410==
==16410== 1,688 (136 direct, 1,552 indirect) bytes in 1 blocks are definitely lost in loss record 329 of 352
==16410==    at 0x4C2C861: realloc (vg_replace_malloc.c:662)
==16410==    by 0x528E42B: ??? (in /usr/lib/x86_64-linux-gnu/libX11.so.6.3.0)
==16410==    by 0x528E8BD: ??? (in /usr/lib/x86_64-linux-gnu/libX11.so.6.3.0)
==16410==    by 0x528FE90: ??? (in /usr/lib/x86_64-linux-gnu/libX11.so.6.3.0)
==16410==    by 0x5290665: _XlcCreateLC (in /usr/lib/x86_64-linux-gnu/libX11.so.6.3.0)
==16410==    by 0x52B1A0F: _XlcUtf8Loader (in /usr/lib/x86_64-linux-gnu/libX11.so.6.3.0)
==16410==    by 0x5297A01: _XOpenLC (in /usr/lib/x86_64-linux-gnu/libX11.so.6.3.0)
==16410==    by 0x5297B47: _XlcCurrentLC (in /usr/lib/x86_64-linux-gnu/libX11.so.6.3.0)
==16410==    by 0x5297B9D: XSetLocaleModifiers (in /usr/lib/x86_64-linux-gnu/libX11.so.6.3.0)
==16410==    by 0x6B4987B: ??? (in /usr/lib/x86_64-linux-gnu/libSDL-1.2.so.0.11.3)
==16410==    by 0x6B4A4A2: ??? (in /usr/lib/x86_64-linux-gnu/libSDL-1.2.so.0.11.3)
==16410==    by 0x6B3AAEC: SDL_VideoInit (in /usr/lib/x86_64-linux-gnu/libSDL-1.2.so.0.11.3)
==16410==
==16410== 1,866,240 bytes in 3 blocks are definitely lost in loss record 352 of 352
==16410==    at 0x4C2C66F: malloc (vg_replace_malloc.c:270)
==16410==    by 0x6B4B9BF: ??? (in /usr/lib/x86_64-linux-gnu/libSDL-1.2.so.0.11.3)
==16410==    by 0x6B3BEE6: SDL_CreateYUVOverlay (in /usr/lib/x86_64-linux-gnu/libSDL-1.2.so.0.11.3)
==16410==    by 0x4A103D: ??? (in /home/michael/ffmpeg-git/ffmpeg/ffplay)
==16410==    by 0xFFF676C: (below main) (libc-start.c:226)

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Dictatorship: All citizens are under surveillance, all their steps and
actions recorded, for the politicians to enforce control.
Democracy: All politicians are under surveillance, all their steps and
actions recorded, for the citizens to enforce control.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160412/b6b0d835/attachment.sig>