[FFmpeg-devel] [PATCH] avcodec: Add bits_per_raw_sample to AVCodecParameters

Michael Niedermayer michael at niedermayer.cc
Mon Apr 11 02:57:00 CEST 2016


On Mon, Apr 11, 2016 at 12:40:43AM +0100, Derek Buitenhuis wrote:
> On 4/11/2016 12:32 AM, Michael Niedermayer wrote:
> > The bits_per_raw_sample represents the number of bits of precission per sample.
> > 
> > The field is added at the logical place, not at the end as the code was just
> > recently added
> > 
> > This fixes the regression about loosing the audio sample precission information
> > 
> > The change in the fate test checksum un-does the change from the merge
> > 
> > Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
> > ---
> >  libavcodec/avcodec.h |   17 +++++++++++++++++
> >  libavcodec/utils.c   |    2 ++
> >  tests/ref/lavf/ffm   |    2 +-
> >  3 files changed, 20 insertions(+), 1 deletion(-)
> 
> Is this ever used for anything other than identifying 24-bit PCM?

dts, flac and wmalossless use it too


> I always wondered why we just didn't have a 24-bit PCM format.
> 

> Also, if this is applied, you should update matroskaenc.c to use it.

i noticed that one already when greping for changes to these fields

thx

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Those who would give up essential Liberty, to purchase a little
temporary Safety, deserve neither Liberty nor Safety -- Benjamin Franklin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160411/709e71b3/attachment.sig>


More information about the ffmpeg-devel mailing list