[FFmpeg-devel] [PATCH 12/13] lavc/videotoolboxenc: Support pixel aspect ratio

[Carl Eugen Hoyos]

Rick Kern <kernrj <at> gmail.com> writes:

> +        if (status) {
> +            av_log(
> +                   avctx,
> +                   AV_LOG_ERROR,
> +                   "Error setting pixel aspect ratio to %d:%d: %d.\n",

Why would the function call fail?

I would expect that the pixel aspect ratio has max 
values, if yes, you first have to av_reduce the sar.

> +                   avctx->sample_aspect_ratio.num,
> +                   avctx->sample_aspect_ratio.den,
> +                   status);
> +
> +            return AVERROR_EXTERNAL;

In any case, printing the error should be enough imo.

Carl Eugen