[FFmpeg-devel] [PATCH] Implement hdcd filtering

Michael Niedermayer michael at niedermayer.cc
Sun Apr 10 03:36:30 CEST 2016


On Sat, Apr 09, 2016 at 11:35:03PM +0200, Benjamin St wrote:
> >
> > Changelog entry and docs update missing
> >
> Fixed
> 
>  has this been tested against some reference / known to be correct
> > output for some stream ?
> 
> It has been tested again examples uploaded at ticket #4441
> 

>  a fate test would still be interresting i think
> 
> If a fate test is really needed (floats are no longer used), I could use
> the files provided at the ticket as a reference.

its not "really needed" but it would good if code is tested so that
regressions are found early.

the filter also seems not to check its input parameters
./ffmpeg -v 99 -i HDCD.flac -af aresample=och=6,hdcd test.wav

segfaults

so does
./ffmpeg -v 99 -i HDCD.flac -af aresample=32000,hdcd test.wav

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The real ebay dictionary, page 3
"Rare item" - "Common item with rare defect or maybe just a lie"
"Professional" - "'Toy' made in china, not functional except as doorstop"
"Experts will know" - "The seller hopes you are not an expert"
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160410/2a16a01c/attachment.sig>


More information about the ffmpeg-devel mailing list