[FFmpeg-devel] [PATCH] fate: Add test for Ticket 2397

[Michael Niedermayer]

On Wed, Apr 06, 2016 at 12:25:48AM +0200, Clément Bœsch wrote:
> On Sat, Apr 02, 2016 at 03:49:12AM +0200, Michael Niedermayer wrote:
> > If someone can create a smaller test file (its 2.5Mb) that still has the same coverage that is welcome.
> > otherwise ill upload the sample attached to the ticket
> > 
> > Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
> > ---
> >  tests/fate/filter-video.mak        |    4 +
> >  tests/filtergraphs/overlay-2397    |    2 +
> >  tests/ref/fate/filter-overlay-2397 |  848 ++++++++++++++++++++++++++++++++++++
> >  3 files changed, 854 insertions(+)
> >  create mode 100644 tests/filtergraphs/overlay-2397
> >  create mode 100644 tests/ref/fate/filter-overlay-2397
> > 
> > diff --git a/tests/fate/filter-video.mak b/tests/fate/filter-video.mak
> > index 7fb7677..5fd6ae0 100644
> > --- a/tests/fate/filter-video.mak
> > +++ b/tests/fate/filter-video.mak
> > @@ -304,6 +304,10 @@ FATE_FILTER-$(call ALLYES, SMJPEG_DEMUXER MJPEG_DECODER PERMS_FILTER HQDN3D_FILT
> >  fate-filter-hqdn3d-sample: tests/data/filtergraphs/hqdn3d
> >  fate-filter-hqdn3d-sample: CMD = framecrc -idct simple -i $(TARGET_SAMPLES)/smjpeg/scenwin.mjpg -filter_complex_script $(TARGET_PATH)/tests/data/filtergraphs/hqdn3d -an
> >  
> > +FATE_FILTER-$(call ALLYES, MATROSKA_DEMUXER OVERLAY_FILTER H264_DECODER DVDSUB_DECODER) += fate-filter-overlay-2397
> > +fate-filter-overlay-2397: tests/data/filtergraphs/overlay-2397
> > +fate-filter-overlay-2397: CMD = framecrc -flags bitexact -i $(TARGET_SAMPLES)/filter/242_4.mkv -filter_complex_script $(TARGET_PATH)/tests/data/filtergraphs/overlay-2397 -c:a copy
> > +
> 
> is it relevant to include the audio?

hmm, the user would likely use audio, so including audio is more
realistic/closer to what a user would do


> 
> also i'd better mention "dvdsub" than the ticket id (commit message should
> still contain the reference to the ticket though).

changed

applied

thanks

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Frequently ignored answer#1 FFmpeg bugs should be sent to our bugtracker. User
questions about the command line tools should be sent to the ffmpeg-user ML.
And questions about how to use libav* should be sent to the libav-user ML.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160408/2979b2ad/attachment.sig>