[FFmpeg-devel] [PATCH] [WIP] Updated MLP encoder - Qualification Task (TrueHD)

Michael Niedermayer michael at niedermayer.cc
Wed Apr 6 00:30:07 CEST 2016


On Wed, Apr 06, 2016 at 02:55:08AM +0530, Jai Luthra wrote:
> Hi,
> 
> On Tue, Apr 05, 2016 at 10:31:44PM +0200, Michael Niedermayer wrote:
> > > Should I squash the commits and send a single patch instead?
> > 
> > a single patch makes more sense for reviewing
> Cool. I've attached the squashed patch for review.
> 
> > > PS: I noticed Disha Singh is also working on this for outreachy. Is it
> > > fine if two applicants work on the same project through different
> > > programs over the summer?
> > 
> > It is possible AFAIK, but its unlikely we will accept 2 students doing
> > exactly the same
> > So far noone has passed the qualfication task for this project though
> I'll complete it and submit for final evaluation within a week.
> Sorry for being late, I was busy with college studies but I'll be completely
> free during the coding period.
> 
> Cheers,
> Jai Luthra

>  Makefile    |    1 
>  alacenc.c   |    4 
>  allcodecs.c |    2 
>  flacenc.c   |    3 
>  lpc.c       |   13 
>  lpc.h       |    2 
>  mlp.c       |   14 
>  mlp.h       |   38 
>  mlpenc.c    | 2426 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  ra144enc.c  |    2 
>  10 files changed, 2495 insertions(+), 10 deletions(-)
> ab5595eae435284664cd4aea4d2f39adbe72fa8b  0001-mlpenc-Add-compilable-mlp-encoder.patch
> From 6190f169d87523af12c9a5187dc3a8019d066c3f Mon Sep 17 00:00:00 2001
> From: Jai Luthra <me at jailuthra.in>
> Date: Wed, 2 Mar 2016 23:08:41 +0530
> Subject: [PATCH] mlpenc: Add compilable mlp encoder

libavcodec/mlpenc.c: In function ‘write_access_unit’:
libavcodec/mlpenc.c:1226:14: warning: variable ‘buf2’ set but not used [-Wunused-but-set-variable]
libavcodec/mlpenc.c: At top level:
libavcodec/mlpenc.c:2422:5: warning: initialization from incompatible pointer type [enabled by default]
libavcodec/mlpenc.c:2422:5: warning: (near initialization for ‘ff_mlp_encoder.encode2’) [enabled by default]
libavcodec/mlpenc.c:682:21: warning: ‘bitcount_restart_header’ defined but not used [-Wunused-function]
libavcodec/mlpenc.c:726:21: warning: ‘bitcount_decoding_params’ defined but not used [-Wunused-function]
libavcodec/mlpenc.c: In function ‘analyze_sample_buffer’:
libavcodec/mlpenc.c:2110:19: warning: ‘best_codebook’ may be used uninitialized in this function [-Wuninitialized]
libavcodec/mlpenc.c:2059:22: note: ‘best_codebook’ was declared here

all build warnings should be fixed 

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I have never wished to cater to the crowd; for what I know they do not
approve, and what they approve I do not know. -- Epicurus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160406/bb4a2615/attachment.sig>


More information about the ffmpeg-devel mailing list