[FFmpeg-devel] Support master branch of OpenJPEG and Grok J2K codecs

[Aaron Boxer]

On Sun, Apr 3, 2016 at 7:02 PM, Michael Bradshaw <mjbshaw at gmail.com> wrote:

> Tested with OpenJPEG 1.5, 2.0, and 2.1 on OS X with clang. Correctly
> decoded and re-encoded the balloon.jp2 sample.
>

Thanks for testing.



>
> On Sun, Apr 3, 2016 at 2:34 PM, Aaron Boxer <boxerab at gmail.com> wrote:
> > From d12c685578f21b403f6c03505edd84db367306c5 Mon Sep 17 00:00:00 2001
> > From: Aaron Boxer <boxerab at gmail.com>
> > Date: Sun, 27 Mar 2016 00:15:20 -0400
> > Subject: [PATCH] Support the following jpeg 2000 codecs:
> >
> > a) latest release of openjpeg (2.1)
> > b) master branch of openjpeg
> > c) grok (https://github.com/GrokImageCompression/grok)
>
> I'm curious what others think: if Grok requires FFmpeg to use GPLv3,
> should an explicit check be added in ./configure to require
> --enable-gpl --enable-version3? Or should the check not be added,
> since FFmpeg is expecting the OpenJPEG library and the user is
> replacing it with something else, so the onus is on them to remember
> to add those flags when configuring?
>

We could add an --enable=libgrok option that would essentially configure
for openjpeg 2.1
but add   --enable-gpl --enable-version3 .  I don't want to presume that I
can have my own configure
setting at this stage :) but it would make this explicit for the user.


>  #include "libavutil/avassert.h"
> >  #include "libavutil/common.h"
> > @@ -276,7 +276,6 @@ static opj_image_t *mj2_create_image(AVCodecContext
> *avctx, opj_cparameters_t *p
> >
> >      for (i = 0; i < numcomps; i++) {
> >          cmptparm[i].prec = desc->comp[i].depth;
> > -        cmptparm[i].bpp  = desc->comp[i].depth;
>
> bpp is needed by opj_j2k_is_cinema_compliant in OpenJPEG 2.1. I'd
> rather not remove this line.
>


Thanks, Michael. Here is an updated patch with the bpp change removed.

Aaron
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Support-the-following-jpeg-2000-codecs.patch
Type: application/octet-stream
Size: 2805 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160403/8559f6ca/attachment.obj>