[FFmpeg-devel] [PATCH] Introduce ff_bprint_to_codecpar_extradata for avformat

[Michael Niedermayer]

On Sun, Apr 03, 2016 at 09:39:12AM +0200, Hendrik Leppkes wrote:
> On Sun, Apr 3, 2016 at 4:07 AM, Michael Niedermayer
> <michael at niedermayer.cc> wrote:
> > On Thu, Mar 31, 2016 at 09:49:02PM +0100, Derek Buitenhuis wrote:
> >> From: Hendrik Leppkes <h.leppkes at gmail.com>
> >>
> >> ---
> >>  libavformat/internal.h |  7 +++++++
> >>  libavformat/utils.c    | 23 +++++++++++++++++++++++
> >>  2 files changed, 30 insertions(+)
> >
> > fine with me / i see nothing wrong,
> > i dont know though what it will be used for
> >
> 
> Its used by text subtitle demuxers to construct format instructions
> straight into extradata.
> They all previously used a similar function that accepted an
> AVCodecContext instead.

please add somethng like this to the commit message
LGTM

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Let us carefully observe those good qualities wherein our enemies excel us
and endeavor to excel them, by avoiding what is faulty, and imitating what
is excellent in them. -- Plutarch
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160403/7642d5a3/attachment.sig>