[FFmpeg-devel] [PATCHv2 1/2] ffplay: add support for interactive volume control

[Ganesh Ajjanagadde]

On Sun, Sep 27, 2015 at 11:40 AM, Clément Bœsch <u at pkh.me> wrote:
> On Sun, Sep 27, 2015 at 10:12:52AM -0400, Ganesh Ajjanagadde wrote:
> [...]
>> Yes, I consider the current usage terrible unless I am missing
>> something. volume filter is static, so once set, I can't adjust the
>> volume until I reinsert a new volume filter, etc. I can't simply
>> adjust the volume like I can with vlc/mpv with a simple keybinding.
>>
>
> There is a process_command() mechanism too if you want to change settings
> on the fly

Hmm... that seems to be a libavfilter thing. We could consider adding
that to the volume filter. However, I consider it independent of this
patch:
a user should not have to do an ffplay foo.mp4 -vf ... just to do
simple dynamic volume adjustment.
Again, my reference point is mpv/cvlc, where no such thing is required.

By the way, the silence_buf thing is currently ok due to the
av_mallocz in stream_open. This will need adjustment if we change
wanted_spec in the future. I see it as requiring no change for the
foreseeable future so I do not consider it worthwhile doing the more
"robust" initialization from the spec.silence value.

>
> --
> Clément B.
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>