[FFmpeg-devel] [PATCH 1/2] dnxhddec: decode and use interlace mb flag

Michael Niedermayer michaelni at gmx.at
Fri Sep 25 20:42:56 CEST 2015


On Fri, Sep 25, 2015 at 06:57:17PM +0200, Christophe Gisquet wrote:
> This bit is 1 in some samples, and seems to coincide with interlaced
> mbs and CID1260. 2008 specs do not know about it, and maintain qscale
> is 11 bits. This looks oversized, but may help larger bitdepths.
> 
> Currently, it leads to an obviously incorrect qscale value, meaning
> its syntax is shifted by 1. However, reading 11 bits also leads to
> obviously incorrect decoding: qscale seems to be 10 bits.
> 
> However, as most profiles still have 11bits qscale, the feature is
> restricted to the CID1260 profile.
> 
> The encoder writes 12 bits of syntax, last and first bits always 0,
> which is now somewhat inconsistent with the decoder, but ends up with
> the same effect (progressive + reserved bit).
> 
> Partially fixes ticket #4876.
> ---
>  libavcodec/dnxhddec.c | 15 ++++++++++++---
>  1 file changed, 12 insertions(+), 3 deletions(-)

applied

thanks

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Its not that you shouldnt use gotos but rather that you should write
readable code and code with gotos often but not always is less readable
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150925/99d6ebc0/attachment.sig>


More information about the ffmpeg-devel mailing list