[FFmpeg-devel] [PATCH 2/3] avformat/vobsub: do not attempt to check duplicate subtitles

[Clément Bœsch]

On Sun, Sep 20, 2015 at 04:12:37PM +0200, wm4 wrote:
> Some .idx files actually contain duplicate subtitle events:
> 
> timestamp: 00:07:52:600, filepos: 00004e800
> timestamp: 00:07:52:600, filepos: 00004f800
> 
> The second will be dropped, because it has same pts, duration, and text
> (the text is just a dummy empty string; the real data is retrieved when
> actually reading vobsub subtitle packets).
> 
> Dropping this is probably not intended/safe, so avoid it.
> ---
>  libavformat/mpeg.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/libavformat/mpeg.c b/libavformat/mpeg.c
> index 223b690..ab1a9ca 100644
> --- a/libavformat/mpeg.c
> +++ b/libavformat/mpeg.c
> @@ -857,6 +857,7 @@ static int vobsub_read_header(AVFormatContext *s)
>  
>      for (i = 0; i < s->nb_streams; i++) {
>          vobsub->q[i].sort = SUB_SORT_POS_TS;
> +        vobsub->q[i].keep_duplicates = 1;
>          ff_subtitles_queue_finalize(s, &vobsub->q[i]);
>      }
>  

If you could open a ticket in the trac with the sample, refer to that
ticket in the description and close the ticket after the push, that would
be awesome.

(then one day, when someone will add regression tests for all the bug
fixes, his/her life will be easier)

Patch is fine with me, thanks

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150920/274b2943/attachment.sig>