[FFmpeg-devel] [PATCH] doc/encoders: add libopenh264 entry

[Stefano Sabatini]

On date Tuesday 2015-09-08 16:49:33 +0200, Clément Bœsch encoded:
> On Tue, Sep 08, 2015 at 03:59:50PM +0200, Stefano Sabatini wrote:
> > ---
> >  doc/encoders.texi | 59 +++++++++++++++++++++++++++++++++++++++++++++++++++++++
> >  1 file changed, 59 insertions(+)
> > 
> > diff --git a/doc/encoders.texi b/doc/encoders.texi
> > index f9fe331..37a0330 100644
> > --- a/doc/encoders.texi
> > +++ b/doc/encoders.texi
> > @@ -1342,6 +1342,65 @@ disabled
> >  A description of some of the currently available video encoders
> >  follows.
> >  
> > + at section libopenh264
> > +
> > +Cisco libopenh264 H.264/MPEG-4 AVC encoder wrapper.
> > +
> > +This encoder requires the presence of the libopenh264 headers and
> > +library during configuration. You need to explicitly configure the
> > +build with @code{--enable-libopenh264}.
> 
> You might want to add "The library is detected using pkg-config"

Done.

> 
> > +
> > +This encoder currently supports only baseline profile.
> 
> Note: I feel like mentioning limitations in the documentation are going to
> be forgotten when the code improves. Maybe we should mention "Update the
> doc" along side the TODO of the feature in the code.

Removed that line, in case the library will be updated.

[...]
> LGTM but I'm not familiar with the encoder

Will push it soon, can be amended later.

Thanks.
-- 
FFmpeg = Fundamentalist and Faithless Merciless Powered Experimenting Geisha