[FFmpeg-devel] [PATCH 2/2] avformat/http: exponentially delay reconnection to avoid flooding the server

Zhang Rui bbcallen at gmail.com
Mon Sep 7 04:53:15 CEST 2015


>> Doesn't this have overflow issues?
>> More precisely, are you sure this behaves correctly when the int
>> reconnect_delay wraps around?
>
> i intend to add a reconnect_max that limits reconnects and prevents
> overflow, just wanted to first make sure noone has objections to
> these 2 patches before i write more code on top

These 2 patches are OK for me.

BTW:
Is it OK to expose generic io_callback in URLContext
to API users to handle such staffs?
Something like open_cb in AVFormatContext.

API users may need various check/action at reconnection,
e.g. checking cellular/wifi, renewing expired url,
injecting custom IO into nested protocols, alert end user.


More information about the ffmpeg-devel mailing list