[FFmpeg-devel] [PATCH 0/4] av_warn_unused_result for avutil/eval

Ganesh Ajjanagadde gajjanagadde at gmail.com
Sat Oct 31 15:47:53 CET 2015

This is an attempt on my end to be more systematic and avoid sloppiness and noise
while sending patches. As can be seen, I have made use of the cover letter
option and have organized an av_warn_unused_result change into one cohesive unit:

1/4 fixes issues of unchecked error codes from av_expr_parse_and_eval, essentially

2/4 fixes an issue I noticed while working on vf_rotate regarding the above.

3/4 cleans up issues in the test build for avutil/eval, so that 4/4 which adds
av_warn_unused_result does not cause warning regressions.

Tested with FATE.
Please reply to this cover letter if you think my attempt at more structured changes
is an improvement over e.g mass av_warn_unused_result changes.

Ganesh Ajjanagadde (4):
  avfilter/all: check and propagate the return code of
  avfilter/vf_rotate: correct log message
  avutil/eval: check av_expr_parse_and_eval error code in the test build
  avutil/eval: add av_warn_unused_result

 libavfilter/vf_pad.c    | 10 ++++++----
 libavfilter/vf_rotate.c |  7 +++----
 libavfilter/vf_scale.c  |  5 +++--
 libavfilter/vf_zscale.c |  5 +++--
 libavutil/eval.c        | 22 +++++++++++++---------
 libavutil/eval.h        |  2 ++
 6 files changed, 30 insertions(+), 21 deletions(-)


More information about the ffmpeg-devel mailing list