[FFmpeg-devel] [PATCH] avutil/opencl_internal: add av_warn_unused_result

[Ganesh Ajjanagadde]

On Thu, Oct 29, 2015 at 4:26 PM, Michael Niedermayer
<michael at niedermayer.cc> wrote:
> On Wed, Oct 28, 2015 at 10:53:59PM -0400, Ganesh Ajjanagadde wrote:
>> On Thu, Oct 15, 2015 at 6:24 PM, Ganesh Ajjanagadde
>> <gajjanagadde at gmail.com> wrote:
>> > Signed-off-by: Ganesh Ajjanagadde <gajjanagadde at gmail.com>
>> > ---
>> >  libavutil/opencl_internal.h | 1 +
>> >  1 file changed, 1 insertion(+)
>> >
>> > diff --git a/libavutil/opencl_internal.h b/libavutil/opencl_internal.h
>> > index dacd930..a4f5885 100644
>> > --- a/libavutil/opencl_internal.h
>> > +++ b/libavutil/opencl_internal.h
>> > @@ -30,4 +30,5 @@ typedef struct {
>> >      void *ctx;
>> >  } FFOpenclParam;
>> >
>> > +av_warn_unused_result
>> >  int avpriv_opencl_set_parameter(FFOpenclParam *opencl_param, ...);
>> > --
>> > 2.6.1
>> >
>>
>> ping
>
> probably ok

Don't think it is ok as is, the header attributes.h needs to be included :).
Added a reference to
https://www.khronos.org/registry/cl/sdk/1.1/docs/man/xhtml/clSetKernelArg.html
since that explains that out of memory errors are possible and thus
need to be propagated.

Pushed with the header include as well due to your general "probably
ok" stance and absence of further comments.

>
> [...]
> --
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>
> Many that live deserve death. And some that die deserve life. Can you give
> it to them? Then do not be too eager to deal out death in judgement. For
> even the very wise cannot see all ends. -- Gandalf
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>