[FFmpeg-devel] [PATCH 01/11] ffmpeg: use log10 instead of log()/log(10)
michael at niedermayer.cc
Fri Oct 30 01:22:13 CET 2015
On Fri, Oct 30, 2015 at 12:50:46AM +0100, Hendrik Leppkes wrote:
> On Fri, Oct 30, 2015 at 12:08 AM, Ganesh Ajjanagadde <gajjanag at mit.edu> wrote:
> > On Thu, Oct 29, 2015 at 8:27 AM, Ronald S. Bultje <rsbultje at gmail.com> wrote:
> >> Hi,
> >> On Thu, Oct 29, 2015 at 8:04 AM, Michael Niedermayer <michael at niedermayer.cc
> >>> wrote:
> >>> On Thu, Oct 29, 2015 at 12:19:59AM -0400, Ganesh Ajjanagadde wrote:
> >>> > This is more concise and conveys the intent better.
> >>> > Furthermore, it is likely more precise as well due to lack of floating
> >>> > point division.
> >>> >
> >>> > Signed-off-by: Ganesh Ajjanagadde <gajjanagadde at gmail.com>
> >>> patchset tested on linux32, inux64, mingw32, ming64, qemu-mips and
> >>> qemu-arm
> >>> fate passes on all, i could test on actual arm&mips hw if people think
> >>> that is needed
> >> I don't think that's needed.
> >> Is there some way we can confirm that each of these files that is changed
> >> includes libavutil/libm.h for the compatibility macros in case they're
> >> lacking on the target system?
> > pushed as is; we have until the next release or a FATE failure to
> > check the build on such obscure configurations. I will try to keep an
> > eye out, but please report if you find failures.
> This is really not the right way to go. You have been notified of a
> real-world portability concern with an easy fix (verify that all files
> you use log2/etc in include libavutil/libm.h), and you decided to wait
> until it blows up instead?
> Not cool.
I think this is partly my fault as i approved several of the patches
after ronalds comment.
I did check most of them for including libm.h
some do through avfilter/interal.h ->avutil/internal.h->libm.h
some do though avutil/common.h->avutil/internal.h->libm.h
of course it is possible i forgot something and i totally didnt
communicate that i did check that
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
When the tyrant has disposed of foreign enemies by conquest or treaty, and
there is nothing more to fear from them, then he is always stirring up
some war or other, in order that the people may require a leader. -- Plato
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 181 bytes
Desc: Digital signature
More information about the ffmpeg-devel