[FFmpeg-devel] [PATCH] avformat: stop exporting ffurl_read_complete, ffurl_seek and ffurl_size

Andreas Cadhalpun andreas.cadhalpun at googlemail.com
Thu Oct 29 23:51:51 CET 2015


On 27.10.2015 22:52, Andreas Cadhalpun wrote:
> On 27.10.2015 22:04, Hendrik Leppkes wrote:
>> On Tue, Oct 27, 2015 at 9:58 PM, Andreas Cadhalpun
>> <andreas.cadhalpun at googlemail.com> wrote:
>>> They are not in public headers and not used outside of libavformat.
>>>
>>> Signed-off-by: Andreas Cadhalpun <Andreas.Cadhalpun at googlemail.com>
>>> ---
>>>
>>> It's been a year since the last attempt to remove these [1].
>>> Bad enough that ffserver still uses private functions, but keeping even
>>> more in the ABI for some unnamed third party applications is just wrong.
>>>
>>> 1: https://ffmpeg.org/pipermail/ffmpeg-devel/2014-August/160951.html
>>>
>>> ---
>>>  libavformat/libavformat.v | 3 ---
>>>  1 file changed, 3 deletions(-)
>>>
>>> diff --git a/libavformat/libavformat.v b/libavformat/libavformat.v
>>> index e90aef7..a00a309 100644
>>> --- a/libavformat/libavformat.v
>>> +++ b/libavformat/libavformat.v
>>> @@ -10,9 +10,6 @@ LIBAVFORMAT_$MAJOR {
>>>                  ffio_set_buf_size;
>>>                  ffurl_close;
>>>                  ffurl_open;
>>> -                ffurl_read_complete;
>>> -                ffurl_seek;
>>> -                ffurl_size;
>>>                  ffurl_write;
>>>                  #those are deprecated, remove on next bump
>>>                  url_feof;
>>> --
>>> 2.6.1
>>>
>>
>> Fine with me.
> 
> OK. I'll wait a bit to see if someone else wants to comment on this patch.

Seems not the case, so pushed now.

Best regards,
Andreas



More information about the ffmpeg-devel mailing list