[FFmpeg-devel] [PATCH] avutil/parseutils: add av_warn_unused_result

Ganesh Ajjanagadde gajjanagadde at gmail.com
Thu Oct 29 23:41:25 CET 2015


On Thu, Oct 15, 2015 at 7:52 PM, Ganesh Ajjanagadde
<gajjanagadde at gmail.com> wrote:
> This triggers a few warnings that will need to be fixed - not that bad,
> the current code is mostly fine.
>
> Signed-off-by: Ganesh Ajjanagadde <gajjanagadde at gmail.com>
> ---
>  libavutil/parseutils.h | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/libavutil/parseutils.h b/libavutil/parseutils.h
> index e66d24b..46de518 100644
> --- a/libavutil/parseutils.h
> +++ b/libavutil/parseutils.h
> @@ -46,6 +46,7 @@
>   * @param[in] log_ctx parent logging context
>   * @return >= 0 on success, a negative error code otherwise
>   */
> +av_warn_unused_result
>  int av_parse_ratio(AVRational *q, const char *str, int max,
>                     int log_offset, void *log_ctx);
>
> @@ -63,6 +64,7 @@ int av_parse_ratio(AVRational *q, const char *str, int max,
>   * width x height or a valid video size abbreviation.
>   * @return >= 0 on success, a negative error code otherwise
>   */
> +av_warn_unused_result
>  int av_parse_video_size(int *width_ptr, int *height_ptr, const char *str);
>
>  /**
> @@ -74,6 +76,7 @@ int av_parse_video_size(int *width_ptr, int *height_ptr, const char *str);
>   * rate_num / rate_den, a float number or a valid video rate abbreviation
>   * @return >= 0 on success, a negative error code otherwise
>   */
> +av_warn_unused_result
>  int av_parse_video_rate(AVRational *rate, const char *str);
>
>  /**
> @@ -95,6 +98,7 @@ int av_parse_video_rate(AVRational *rate, const char *str);
>   * @return >= 0 in case of success, a negative value in case of
>   * failure (for example if color_string cannot be parsed).
>   */
> +av_warn_unused_result
>  int av_parse_color(uint8_t *rgba_color, const char *color_string, int slen,
>                     void *log_ctx);
>
> @@ -143,6 +147,7 @@ const char *av_get_known_color_name(int color_idx, const uint8_t **rgb);
>   * @return >= 0 in case of success, a negative value corresponding to an
>   * AVERROR code otherwise
>   */
> +av_warn_unused_result
>  int av_parse_time(int64_t *timeval, const char *timestr, int duration);
>
>  /**
> --
> 2.6.1
>

Pinged the wrong mail, here is the patch. Sorry.


More information about the ffmpeg-devel mailing list