[FFmpeg-devel] [PATCH] avcodec/motion_est_template: replace qsort with AV_QSORT

Ganesh Ajjanagadde gajjanag at mit.edu
Thu Oct 29 02:45:40 CET 2015


On Wed, Oct 28, 2015 at 10:00 AM, Michael Niedermayer
<michael at niedermayer.cc> wrote:
> On Tue, Oct 27, 2015 at 10:51:29PM -0400, Ganesh Ajjanagadde wrote:
>> This code is in a performance critical section. AV_QSORT is
>> substantially faster due to the inlining of the comparison callback.
>> Thus, the increase in performance is worth the increase in binary size.
>>
>> Signed-off-by: Ganesh Ajjanagadde <gajjanagadde at gmail.com>
>> -------------------------------------------------------------------------------
>> Benchmarks not provided, since FATE does not seem to exercise this.
>> Left to the maintainer/any interested.
>> ---
>>  libavcodec/motion_est_template.c | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> LGTM
>
> (if someone wants to benchmark see the -dia_size parameter)
>
> thx

pushed, thanks.

>
> [...]
> --
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>
> The real ebay dictionary, page 2
> "100% positive feedback" - "All either got their money back or didnt complain"
> "Best seller ever, very honest" - "Seller refunded buyer after failed scam"
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>


More information about the ffmpeg-devel mailing list