[FFmpeg-devel] [PATCHv2] all: fix enum definition for large values
gajjanag at mit.edu
Wed Oct 28 19:32:16 CET 2015
On Wed, Oct 28, 2015 at 11:44 AM, Clément Bœsch <u at pkh.me> wrote:
> On Wed, Oct 28, 2015 at 10:34:37AM -0400, Ronald S. Bultje wrote:
>> You could do the same for the last 4 values of the cinething changes, they
>> are clearly not enums, but flags. Flags are always unsigned, so if enums
>> are unsigned and that causes an issue (as it does here), it makes sense to
>> fix that at its root, i.e. by making the value unsigned and it thus also
>> being a macro instead of an enum. Again, only the last 4 elements, the
>> first 5 appear to be genuine enums.
> I support this (or just remove the entries altogether since unused).
I will change this, only issue of contention is the mov_chan one for
which I still feel my solution is better than proposed alternatives.
> Clément B.
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
More information about the ffmpeg-devel