[FFmpeg-devel] [PATCH] avutil/avstring: add av_warn_unused_result

[Hendrik Leppkes]

On Wed, Oct 28, 2015 at 4:17 AM, Ganesh Ajjanagadde
<gajjanagadde at gmail.com> wrote:
> On Thu, Oct 15, 2015 at 6:05 PM, Ganesh Ajjanagadde
> <gajjanagadde at gmail.com> wrote:
>> Signed-off-by: Ganesh Ajjanagadde <gajjanagadde at gmail.com>
>> ---
>>  libavutil/avstring.h | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/libavutil/avstring.h b/libavutil/avstring.h
>> index a306e89..a46d012 100644
>> --- a/libavutil/avstring.h
>> +++ b/libavutil/avstring.h
>> @@ -339,6 +339,7 @@ enum AVEscapeMode {
>>   * @return the length of the allocated string, or a negative error code in case of error
>>   * @see av_bprint_escape()
>>   */
>> +av_warn_unused_result
>>  int av_escape(char **dst, const char *src, const char *special_chars,
>>                enum AVEscapeMode mode, int flags);
>>
>> @@ -378,6 +379,7 @@ int av_escape(char **dst, const char *src, const char *special_chars,
>>   * @return >= 0 in case a sequence was successfully read, a negative
>>   * value in case of invalid sequence
>>   */
>> +av_warn_unused_result
>>  int av_utf8_decode(int32_t *codep, const uint8_t **bufp, const uint8_t *buf_end,
>>                     unsigned int flags);
>>
>> --
>> 2.6.1
>>
>
> In the absence of any comments on this (or other avutil patches, in
> spite of the general ping), the lack of a maintainer in MAINTAINERS,
> and the inactivity/absence of a significant fraction of the people
> listed by a git blame on this file, I took point 12 of the official
> development policy and pushed the change.
>
> Please take this as a call to review the others if interested by this
> weekend, else will begin pushing others at my discretion keeping the
> development policy in view.

Common practice in such a case is to at least ping a change that went
without review once, just in case it was missed on the ML on a busy
day.

- Hendrik