[FFmpeg-devel] [PATCH] avformat/rtpdec_mpa_robust: change assignment to equality test in conditional

Ganesh Ajjanagadde gajjanagadde at gmail.com
Wed Oct 28 00:58:03 CET 2015


In the spirit of commit 8199908fdf9b3797cceaea9d1e2fc09d02ef7309, likely
typo originally.

Found by enabling -Wparentheses on clang 3.7 and running a manual audit.
To the best of my knowledge, no such instances remain.

Signed-off-by: Ganesh Ajjanagadde <gajjanagadde at gmail.com>
---
 libavformat/rtpdec_mpa_robust.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavformat/rtpdec_mpa_robust.c b/libavformat/rtpdec_mpa_robust.c
index 6442a42..91ee98a 100644
--- a/libavformat/rtpdec_mpa_robust.c
+++ b/libavformat/rtpdec_mpa_robust.c
@@ -166,7 +166,7 @@ static int mpa_robust_parse_packet(AVFormatContext *ctx, PayloadContext *data,
             "Received packet without a start fragment; dropping.\n");
         return AVERROR(EAGAIN);
     }
-    if (adu_size = data->adu_size ||
+    if (adu_size == data->adu_size ||
         data->timestamp != *timestamp) {
         ffio_free_dyn_buf(&data->fragment);
         av_log(ctx, AV_LOG_ERROR, "Invalid packet received\n");
-- 
2.6.2



More information about the ffmpeg-devel mailing list