[FFmpeg-devel] [libav-devel] [PATCH] opusdec: Don't run vector_fmul_scalar on zero length arrays

[Hendrik Leppkes]

On Mon, Oct 26, 2015 at 11:29 PM, Kieran Kunhya <kierank at obe.tv> wrote:
> From a1314d5c9774d555718bbc0a8612144c890bbc59 Mon Sep 17 00:00:00 2001
> From: Kieran Kunhya <kierank at obe.tv>
> Date: Mon, 26 Oct 2015 22:26:35 +0000
> Subject: [PATCH] opusdec: Don't run vector_fmul_scalar on zero length arrays
>
> Fixes crashes on fuzzed files
>
> ---
>  libavcodec/opusdec.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavcodec/opusdec.c b/libavcodec/opusdec.c
> index acae6e1..03dd872 100644
> --- a/libavcodec/opusdec.c
> +++ b/libavcodec/opusdec.c
> @@ -587,7 +587,7 @@ static int opus_decode_packet(AVCodecContext
> *avctx, void *data,
>              memset(frame->extended_data[i], 0, frame->linesize[0]);
>          }
>
> -        if (c->gain_i) {
> +        if (c->gain_i && decoded_samples >= 8) {
>              c->fdsp.vector_fmul_scalar((float*)frame->extended_data[i],
>                                         (float*)frame->extended_data[i],
>                                         c->gain, FFALIGN(decoded_samples, 8));

> 0 might be less arbitrary.