[FFmpeg-devel] [PATCH] Adds support parsing the QuickTime Metadata Keys.

[Derek Buitenhuis]

On 10/23/2015 7:41 PM, Tinglin Liu wrote:
> ​
> http://stackoverflow.com/questions/3457968/snprintf-simple-way-to-force-as-radix
> ​
> Here it mentioned using the setlocale() function, but I didn't find any
> examples elsewhere though....
> 
> Derek, would you do the amend and push? Let me know if you need me to
> resend an amended patch. Thanks.

This may be enough of a pain that it needs a wrapper function... e.g. on POSIX,
it says the locale is common to all threads in a process, but on Windows, you
have _configthreadlocale, to define the behavior, and I'm not sure how systems
like Solaris work. I'm not sure how setting the locale could mess with other
bits of the library running concurrently, or worse, a user application which
links to libavformat may/will be affected.

I hate to hold up this patch for spec-arguign reasons, but this *should* probably
be addressed somehow. Lordy, C locales are crap.

Perhaps wm4 or Michael or someone can chime in... I don't know of a single good
way to handle this. Just failing if the locale has a radix point as a comma instead
of a period seems less bad than mucking with the thread/process locale inside a
library.

- Derek