[FFmpeg-devel] [PATCH 1/3] avfilter/vf_deshake: use a void * comparator for consistency

[wm4]

On Sat, 24 Oct 2015 18:02:36 -0400
Ganesh Ajjanagadde <gajjanagadde at gmail.com> wrote:

> For generality, qsort uses a comparator whose elements are void *. This
> makes the comparator have such a form, and thus makes the void * cast of
> the comparator pointer useless. Furthermore, this makes the code more
> consistent with other usages of qsort across the codebase.
> 
> Signed-off-by: Ganesh Ajjanagadde <gajjanagadde at gmail.com>
> ---

Entire patchset (1-3) LGTM, if it really does not cause new warnings.

Maybe instead of "libc" it would be good to write "Standard C", but it
probably doesn't matter at all.