[FFmpeg-devel] [PATCH 1/5] all: fix -Wextra-semi reported on clang

Ganesh Ajjanagadde gajjanag at mit.edu
Sat Oct 24 22:16:56 CEST 2015


On Sat, Oct 24, 2015 at 4:12 PM, Michael Niedermayer
<michael at niedermayer.cc> wrote:
> On Sat, Oct 24, 2015 at 09:33:22AM -0400, Ganesh Ajjanagadde wrote:
>> Hi all,
>>
>> Apologies for the copy/pasted patch, but can't send via send-email.
>> Copy pasted for review below, attached also for a non-clobbered
>> version.
>>
>> --------------------------------------------------------------------------
>>
>> From 82b889a359925d1f9f7496c916cf24146b44e648 Mon Sep 17 00:00:00 2001
>> From: Ganesh Ajjanagadde <gajjanagadde at gmail.com>
>> Date: Fri, 23 Oct 2015 11:23:42 -0400
>> Subject: [PATCH 1/5] all: fix -Wextra-semi reported on clang
>>
>> This fixes extra semicolons that clang 3.7 on GNU/Linux warns about.
>> These were trigggered when built under -Wpedantic, which essentially
>> checks for strict ISO compliance in numerous ways.
>>
>> Signed-off-by: Ganesh Ajjanagadde <gajjanagadde at gmail.com>
>> ---
>>  ffprobe.c                                   |  20 +-
>>  libavcodec/x86/hevcdsp_init.c               | 637 ++++++++++++++--------------
>>  libavcodec/x86/rv40dsp_init.c               |   2 +-
>>  libavcodec/x86/vp9dsp_init.c                |  14 +-
>>  libavcodec/x86/vp9dsp_init.h                |   6 +-
>>  libavcodec/x86/vp9dsp_init_16bpp_template.c |  36 +-
>>  libavdevice/alsa.c                          |   6 +-
>>  7 files changed, 358 insertions(+), 363 deletions(-)
>
> removing one of duplicate or unneeded ; should be ok

sorry, did not follow: are you suggesting a commit message rewording?

>
> [...]
>
> --
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>
> Many that live deserve death. And some that die deserve life. Can you give
> it to them? Then do not be too eager to deal out death in judgement. For
> even the very wise cannot see all ends. -- Gandalf
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>


More information about the ffmpeg-devel mailing list