[FFmpeg-devel] [PATCH 2/5] all: fix incorrect usage of %p format specifier

[Ganesh Ajjanagadde]

On Sat, Oct 24, 2015 at 9:44 AM, Nicolas George <george at nsup.org> wrote:
> Le tridi 3 brumaire, an CCXXIV, Ganesh Ajjanagadde a écrit :
>> Apologies for the copy/pasted patch, but can't send via send-email.
>
> Maybe you should take some time to tackle your email troubles?

I have spent some time on this. Given up on gmail, as it is not in my
control, and is inconsistent. I have tried following my university's
mail configuration, but it does not work. Will need to speak with them
at some point. Until then, I view this is a reasonable compromise for
large patches.

>
>> ISO C %p format specifier applies to void * data pointers. This casts
>> relevant pointers to void * in order to be strictly correct C.
>>
>> Found by -Wpedantic on clang 3.7 (in particular -Wformat-pedantic).
>
> I am rather against this change, it makes the code significantly less
> readable, and this instance I see zero chances of it fixing an actual issue
> any time.
>
> There is a reason these warnings are called "pedantic": there are often
> irrelevant.
>
> Regards,
>
> --
>   Nicolas George
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel