[FFmpeg-devel] [PATCH] avutil: install des.h, rc4.h and tree.h as public headers
george at nsup.org
Wed Oct 14 16:50:09 CEST 2015
Le duodi 22 vendémiaire, an CCXXIV, James Almer a écrit :
> Since these two were never installed, we can remove the FF_API_CRYPTO_CONTEXT
> wrapper from them before applying this patch, as this would be the first time
> the API becomes public.
> Now, what i want to know is what will it be in the end for the actual
> deprecation in question? Reimar and Nicolas were against making the context
> opaque as having them in stack has its uses.
> I want to know what people want, since the deprecation is not present on any
> release and we still have time to rollback. Do we keep the deprecation in
> place for des, rc4, blowfish and xtea, or remove it altogether?
The reason for my objection are that the odds that the contents of the
context change in the future are very small for low-level standardized
crypto functions (this is the reason for making structure opaques). On the
other hand, foregoing the checks for memory allocations is nice, and crypto
functions may be used in speed-critical portions of the code where memory
allocations are not negligible.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 819 bytes
Desc: Digital signature
More information about the ffmpeg-devel