[FFmpeg-devel] [PATCH] intmath: remove av_ctz.

Andreas Cadhalpun andreas.cadhalpun at googlemail.com
Wed Oct 14 00:51:20 CEST 2015


On 13.10.2015 04:21, Michael Niedermayer wrote:
> On Mon, Oct 12, 2015 at 08:15:10PM +0200, Andreas Cadhalpun wrote:
>> It seems several headers are intended to be installed, but actually aren't:
> 
>> libavutil/des.h:
>>  av_des_alloc
>>  av_des_crypt
>>  av_des_init
>>  av_des_mac
>> libavutil/rc4.h:
>>  av_rc4_alloc
>>  av_rc4_crypt
>>  av_rc4_init
>> libavutil/tree.h
>>  av_tree_destroy
>>  av_tree_enumerate
>>  av_tree_find
>>  av_tree_insert
>>  av_tree_node_alloc
>>  av_tree_node_size
> 
> the ones above are IMHO intended to be public

I sent a patch to install them.

What about libavcodec/avdct.h?
You added it last year in commit 932ff70 with the comment:
"This provides a public sustainable API/ABI for DCT functions."
So I'm pretty sure it should be installed.

I'm not sure about libavformat/avlanguage.h and libavfilter/transform.h.
But since they are not mentioned in APIchanges, they were probably
not intended to be public. Should we just rename the functions to ff_*?

libavcodec/audioconvert.h contains only deprecated stuff.
Since this header isn't installed anymore, it could be removed,
except that FF_API_AVCODEC_RESAMPLE still needs it.
Let's just not bother with this until it gets removed.

Best regards,
Andreas


More information about the ffmpeg-devel mailing list