[FFmpeg-devel] [PATCH] avfilter, swresample, swscale: use fabs, fabsf instead of FFABS

Ganesh Ajjanagadde gajjanag at mit.edu
Wed Oct 14 00:46:51 CEST 2015


On Tue, Oct 13, 2015 at 9:12 AM, Ganesh Ajjanagadde <gajjanag at mit.edu> wrote:
> On Tue, Oct 13, 2015 at 4:02 AM, Clément Bœsch <u at pkh.me> wrote:
>> On Tue, Oct 13, 2015 at 09:25:03AM +0200, Paul B Mahol wrote:
>> [...]
>>> What about fmax/FFMAX?
>>
>> Feel free to try that out (it looks OT regarding the patch), but fmax()
>> looks glibc specific

Seems they are actually ISO:
http://en.cppreference.com/w/c/numeric/math/fmax

Can someone check availability on all of our platforms of interest
(e.g Microsoft)?

>
> Maybe (long term) we can use an av_fabs, av_fabsf, av_fmin/av_fmax (or
> ff_, avpriv_, etc) that pick out the right thing for different
> configurations. It will need something split between configure/header
> guards. I am willing to do this, once everyone is convinced.
>
>>
>> --
>> Clément B.
>>
>> _______________________________________________
>> ffmpeg-devel mailing list
>> ffmpeg-devel at ffmpeg.org
>> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>>


More information about the ffmpeg-devel mailing list