[FFmpeg-devel] [PATCHv2 1/2] avfilter/all: propagate errors of functions from avfilter/formats
gajjanag at mit.edu
Mon Oct 12 16:37:54 CEST 2015
On Mon, Oct 12, 2015 at 9:53 AM, Michael Niedermayer
<michael at niedermayer.cc> wrote:
> On Sun, Oct 11, 2015 at 08:39:24PM -0400, Ganesh Ajjanagadde wrote:
>> On Sat, Oct 10, 2015 at 9:47 AM, Nicolas George <george at nsup.org> wrote:
>> > Le nonidi 19 vendémiaire, an CCXXIV, Clement Boesch a écrit :
>> >> You could change that last function to return AVERROR(ENOMEM) in case a
>> >> parameter is NULL, but that's weird semantic.
>> > Since it is an internal function, it is not really a problem, and it makes
>> > for nice simplifications.
>> Any other issues before I work on a new patch? The reason I ask is
>> that the diff is pretty big, and I ideally don't want to have to go
>> through every one of the 60+ files again.
> i get a build failure with it here:
> CC libavfilter/vf_frei0r.o
> libavfilter/vf_frei0r.c: In function ‘query_formats’:
> libavfilter/vf_frei0r.c:393:1: error: control reaches end of non-void function [-Werror=return-type]
Sorry about that - there are some avfilter files that are not built
with a standard ./configure (including this one). It is a trivial fix,
just return the thing and forget the conditional. Done locally.
> Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
> Complexity theory is the science of finding the exact solution to an
> approximation. Benchmarking OTOH is finding an approximation of the exact
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
More information about the ffmpeg-devel