[FFmpeg-devel] [FFmpeg-cvslog] avconv: Do not try to configure filter outputs without streams

[Michael Niedermayer]

On Sat, Oct 10, 2015 at 09:31:05AM -0400, Ganesh Ajjanagadde wrote:
> On Sat, Oct 10, 2015 at 9:18 AM, Michael Niedermayer
> <michael at niedermayer.cc> wrote:
> > Hi
> >
> > On Sat, Oct 10, 2015 at 09:43:55AM +0200, Luca Barbato wrote:
> >> ffmpeg | branch: master | Luca Barbato <lu_zero at gentoo.org> | Mon Oct  5 20:49:55 2015 +0200| [8b830ee9a26d47b138f12a82085cdb372f407f1e] | committer: Luca Barbato
> >>
> >> avconv: Do not try to configure filter outputs without streams
> >>
> >> Prevent a NULL-dereference.
> >>
> >> CC: libav-stable at libav.org
> >>
> >> > http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=8b830ee9a26d47b138f12a82085cdb372f407f1e
> >
> > this is not good
> > we already have code in configure_output_filter that checks
> > ofilter->ost != NULL and prints a clear warning in that case
> >
> > example:
> > ./ffmpeg -f lavfi -i color -f lavfi -i color -filter_complex "[1]null[x],[0][1]overlay" -f null -
> > before:
> > Filter null has a unconnected output
> > after:
> > Output pad "default" with type video of the filter instance "Parsed_null_0" of null not connected to any destination
> > Error configuring complex filters.
> > Invalid argument
> >
> > anyone against reverting this ?
> 
> No, I agree with your reasoning; the error message before was definitely clear.

applied

thanks

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Good people do not need laws to tell them to act responsibly, while bad
people will find a way around the laws. -- Plato
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20151011/c7ee90be/attachment.sig>